Review request for JDK-8006949: Update hotspot for MethodParameters format change

John Rose john.r.rose at oracle.com
Mon Jan 28 18:13:04 PST 2013


Good. Count me as a reviewer. 

You should file a tracking bug for removing the old format. I suggest putting the bug id in a nearby comment. (I think in this case it's good to put in a bug number because it is a transient comment that helps clean the code.)

If there are detailed reg tests that detect the 0x10000 flag that was changed to 0x8000 consider translating it in 4-byte mode, for a smoother ride. 

Nice job!

-- John  (on my iPhone)

On Jan 28, 2013, at 5:45 PM, Eric McCorkle <eric.mccorkle at oracle.com> wrote:

> I have posted a new webrev with code that is capable of loading
> classfiles with both 2 and 4 byte flags fields.
> 
> Again, consider 4 byte flags fields to be temporary; *do not* count on
> this ability in future versions.


More information about the hotspot-dev mailing list