RFR (S): CR 8012939: @Contended doesn't work correctly with inheritance
Coleen Phillimore
coleen.phillimore at oracle.com
Mon May 13 14:53:16 PDT 2013
On 5/13/2013 5:28 PM, Vladimir Kozlov wrote:
> On 5/13/13 2:23 PM, Aleksey Shipilev wrote:
>> On 05/14/2013 01:15 AM, Vladimir Kozlov wrote:
>>> Calculation of orig_nonstatic_field_size variable is also wrong. It
>>> does not take into account fields padding. But it is not important.
>>> We can skip PrintCompactFieldsSavings code if class or its fields are
>>> contended because we don't care about compaction in such case.
>>
>> That, btw, makes me wonder: do we care about PrintCompactFieldsSavings
>> anymore? Can we purge it to make the field layout code more readable?
>
> It was used during fields reordering work but I doubt anyone used it
> since then. We can get similar info from fields layout output.
>
> I agree with removing it but as separate RFE changes.
That would be nice. I'll file or copy me on that RFE. This code is
almost impossible to follow. Thank you Vladimir for doing this code
review.
Coleen
>
> Vladimir
>
>>
>> -Aleksey.
>>
More information about the hotspot-dev
mailing list