RFR (S): CR 8012939: @Contended doesn't work correctly with inheritance

Aleksey Shipilev aleksey.shipilev at oracle.com
Mon May 13 14:49:07 PDT 2013


On 05/14/2013 01:28 AM, Vladimir Kozlov wrote:
> On 5/13/13 2:23 PM, Aleksey Shipilev wrote:
>> On 05/14/2013 01:15 AM, Vladimir Kozlov wrote:
>>> Calculation of orig_nonstatic_field_size variable is also wrong. It
>>> does not take into account fields padding. But it is not important.
>>> We can skip PrintCompactFieldsSavings code if class or its fields are
>>> contended because we don't care about compaction in such case.
>>
>> That, btw, makes me wonder: do we care about PrintCompactFieldsSavings
>> anymore? Can we purge it to make the field layout code more readable?
> 
> It was used during fields reordering work but I doubt anyone used it
> since then. We can get similar info from fields layout output.
> 
> I agree with removing it but as separate RFE changes.

Sounds good, I'll submit the PrintCompactFieldsSavings first then, and
base off my @Contended fix off that after.

-Aleksey.



More information about the hotspot-dev mailing list