RFR (S) CR 8014878: Clean up class field layout code
Aleksey Shipilev
aleksey.shipilev at oracle.com
Mon May 20 22:19:56 PDT 2013
Thanks!
-Aleksey.
On 05/21/2013 06:03 AM, Vladimir Kozlov wrote:
> The job in JPRT queue.
>
> Vladimir
>
> On 5/20/13 12:46 PM, Aleksey Shipilev wrote:
>> On 05/20/2013 10:31 PM, Coleen Phillimore wrote:
>>>
>>> On 05/20/2013 01:33 PM, Aleksey Shipilev wrote:
>>>> On 05/20/2013 08:29 PM, Vladimir Kozlov wrote:
>>>>> Looks good.
>>>> Thanks for the review!
>>>>
>>>>> Could you fix indentions in lines 3176 (move 1 space left), 3572
>>>>> (move 1
>>>>> space right)?
>>>> Done:
>>>> http://cr.openjdk.java.net/~shade/8014878/webrev.02/
>>>>
>>>> We still need a second reviewer, right?
>>>> Coleen, I bet you are anxious to see that method being refactored.
>>>
>>> This looks good and helpful.
>>
>> Thanks for the review!
>>
>> The changeset is here:
>> http://cr.openjdk.java.net/~shade/8014878/8014878.01.changeset
>>
>> Please sponsor :)
>>
>> -Aleksey.
>>
More information about the hotspot-dev
mailing list