RFR (XXS): 8037962: metaspaceTracer.cpp misses a symbol

[Mikael Gerdin]

On Thursday 20 March 2014 12.02.30 Coleen Phillimore wrote:
> Looks good.  Or we should have JPRT do a build without precompiled
> headers to prevent these.

Doing a build is unfortunately not enough, the undefined symbols problem only 
shows up when you try to launch the JVM.
As I mentioned below we should link with -Wl,-z,defs to inform the linker to 
not accept any undefined symbols for libjvm.so.

I'm not touching the makefiles with a 10' pole though, so I'll try to get 
someone else to do it for me.

/Mikael

> Coleen
> 
> On 3/20/14 11:18 AM, Erik Helin wrote:
> > Thomas and Mikael,
> > 
> > thanks for the quick reviews!
> > 
> > Erik
> > 
> > On 03/20/2014 04:15 PM, Thomas Schatzl wrote:
> >> Hi Erik,
> >> 
> >> On Thursday 20 March 2014 16.06.56 Erik Helin wrote:
> >>>   Hi all,
> >>>   
> >>>   this small patch fixes an issue when compiling metaspaceTracer.cpp
> >>> 
> >>> with
> >>> 
> >>>   OPENJDK=true and USE_PRECOMPILED_HEADER=0. The problem is that the
> >>>   symbol oopDesc::klass() is missing, this is fixed by including
> >>>   oops/oop.inline.hpp.
> >>>   
> >>>   Thanks to Goetz Lindenmaier for finding this issue!
> >>>   
> >>>   Webrev:
> >>>   http://cr.openjdk.java.net/~ehelin/8037962/webrev.00/
> >> 
> >> Looks good.
> >> 
> >> Thanks,
> >> Thomas