RFR(xs): 8078628: linux-zero does not build without precompiled header

Thomas Stüfe thomas.stuefe at gmail.com
Mon Apr 27 07:52:34 UTC 2015


Hi David,

stupid copy-paste error. I corrected that and the places where I found it:

http://cr.openjdk.java.net/~stuefe/webrevs/8078628/webrev.01/webrev/

Kind Regards, Thomas

On Mon, Apr 27, 2015 at 2:40 AM, David Holmes <david.holmes at oracle.com>
wrote:

> Hi Thomas,
>
>
> On 25/04/2015 3:11 AM, Thomas Stüfe wrote:
>
>> Hi all,
>>
>> please review this tiny change. Build was broken for zero/slowdebug when
>> building without precompiled header.
>>
>> bug:       https://bugs.openjdk.java.net/browse/JDK-8078628
>> webrev:
>> http://cr.openjdk.java.net/~stuefe/webrevs/8078628/webrev.00/webrev/
>>
>
> Why the double condition here:
>
>   33 #ifdef ZERO
>   34 #ifdef TARGET_ARCH_zero
>   35 # include "entry_zero.hpp"
>   36 #endif
>   37 #endif
>
> ??
>
> Thanks,
> David
>
>
>> Thank you,
>>
>> Thomas
>>
>>


More information about the hotspot-dev mailing list