RFR(xs): 8078628: linux-zero does not build without precompiled header
Stefan Karlsson
stefan.karlsson at oracle.com
Mon Apr 27 08:01:59 UTC 2015
Hi Thomas,
On 2015-04-27 02:40, David Holmes wrote:
> Hi Thomas,
>
> On 25/04/2015 3:11 AM, Thomas Stüfe wrote:
>> Hi all,
>>
>> please review this tiny change. Build was broken for zero/slowdebug when
>> building without precompiled header.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8078628
>> webrev:
>> http://cr.openjdk.java.net/~stuefe/webrevs/8078628/webrev.00/webrev/
The includes are kept sorted in other part of HotSpot, so I think it
would be good to have them sorted for the zero code as well:
http://cr.openjdk.java.net/~stuefe/webrevs/8078628/webrev.01/webrev/src/share/vm/interpreter/interpreterGenerator.hpp.udiff.html
#include "interpreter/cppInterpreter.hpp"
+#include "interpreter/interp_masm.hpp"
#include "interpreter/cppInterpreterGenerator.hpp"
#include "interpreter/templateInterpreter.hpp"
#include "interpreter/templateInterpreterGenerator.hpp"
http://cr.openjdk.java.net/~stuefe/webrevs/8078628/webrev.01/webrev/src/cpu/zero/vm/nativeInst_zero.cpp.udiff.html
#include "precompiled.hpp"
#include "assembler_zero.inline.hpp"
+#include "interpreter/cppInterpreter.hpp"
#include "memory/resourceArea.hpp"
#include "nativeInst_zero.hpp"
+#include "entry_zero.hpp"
#include "oops/oop.inline.hpp"
#include "runtime/handles.hpp"
#include "runtime/sharedRuntime.hpp"
Thanks,
StefanK
>
> Why the double condition here:
>
> 33 #ifdef ZERO
> 34 #ifdef TARGET_ARCH_zero
> 35 # include "entry_zero.hpp"
> 36 #endif
> 37 #endif
>
> ??
>
> Thanks,
> David
>
>>
>> Thank you,
>>
>> Thomas
>>
More information about the hotspot-dev
mailing list