8068054: AARCH64: Assembler interpreter, shared runtime

Andrew Haley aph at redhat.com
Tue Jan 20 15:35:51 UTC 2015


On 01/15/2015 07:49 PM, Vladimir Kozlov wrote:
> Looks good to me.
> 
> One thing caught my eye is relocInfo_aarch64.hpp:
> 
> // FIXME for AARCH64
> 
> The values there are similar to relocInfo_x86.hpp.
> 
> Do you still need to adjust them?

The granularity of AArch64 relocs varies, but the smallest is one
byte.  We don't use format() for anything.  (Perhaps we should, as it
would make the gnarly code that handles relocs simpler and faster, but
that's for another day.)

So this is what I've ended up with:

  29   // machine-dependent parts of class relocInfo
  30  private:
  31   enum {
  32     // Relocations are byte-aligned.
  33     offset_unit        =  1,
  34     // We don't use format().
  35     format_width       =  0
  36   };

Webrev at http://cr.openjdk.java.net/~aph/aarch64-8068054-5/

Thanks,
Andrew.


More information about the hotspot-dev mailing list