8068054: AARCH64: Assembler interpreter, shared runtime

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Jan 20 17:42:56 UTC 2015


Fine with me if it works for you.

I will push it today.

Thanks,
Vladimir

On 1/20/15 7:35 AM, Andrew Haley wrote:
> On 01/15/2015 07:49 PM, Vladimir Kozlov wrote:
>> Looks good to me.
>>
>> One thing caught my eye is relocInfo_aarch64.hpp:
>>
>> // FIXME for AARCH64
>>
>> The values there are similar to relocInfo_x86.hpp.
>>
>> Do you still need to adjust them?
>
> The granularity of AArch64 relocs varies, but the smallest is one
> byte.  We don't use format() for anything.  (Perhaps we should, as it
> would make the gnarly code that handles relocs simpler and faster, but
> that's for another day.)
>
> So this is what I've ended up with:
>
>    29   // machine-dependent parts of class relocInfo
>    30  private:
>    31   enum {
>    32     // Relocations are byte-aligned.
>    33     offset_unit        =  1,
>    34     // We don't use format().
>    35     format_width       =  0
>    36   };
>
> Webrev at http://cr.openjdk.java.net/~aph/aarch64-8068054-5/
>
> Thanks,
> Andrew.
>


More information about the hotspot-dev mailing list