RFR(L): 8130654: ppc: implement MultiplyToLen intrinsic

[Volker Simonis]

Hi Goetz,

the change looks good now.
Thank you and thumbs up!

Volker


On Sat, Jul 11, 2015 at 5:38 PM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> Hi Volker,
>
> thanks for looking at this!
> I fixed frame_ppc and ppc.ad.  I also use R1_SP
> in stubGenerator.
>
> But I left the use of the registers as is.  As the registers
> spilled contain 'real' values and can only be used as
> temp after they are spilled.  I think this is expressed by
> the current wording quite well.
>
> updated webrev:
> http://cr.openjdk.java.net/~goetz/webrevs/8130654-mulToLen/webrev.02/
>
> Best regards,
>   Goetz.
>
> -----Original Message-----
> From: Volker Simonis [mailto:volker.simonis at gmail.com]
> Sent: Freitag, 10. Juli 2015 16:48
> To: Lindenmaier, Goetz
> Cc: hotspot-dev at openjdk.java.net; Januschke, Peter
> Subject: Re: RFR(L): 8130654: ppc: implement MultiplyToLen intrinsic
>
> Hi Goetz,
>
> the change looks good.
>
> I have just a few minor remarks:
>
> frame_ppc.inline.hpp
> - please update the copyright year
>
> vm_version_ppc.cpp
> - you removed UseNewFastLockPPC64 - can you please also remove the
> last occurrence in  ppc.ad
>
> stubGenerator_ppc.cpp
> - once you already declared the various temp registers, maybe you can
> also use these temp names for spilling? This could avoid potential
> problems if somebody changes one of the temp registers. And you could
> also use R1_SP instead of R1 to make it more clear that R1 is the SP.
>
> Regards,
> Volker
>
>
> On Tue, Jul 7, 2015 at 10:47 AM, Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com> wrote:
>> Hi,
>>
>> Peter ported the multiplyToLen intrinsic for ppc.
>> Please review this change
>> http://cr.openjdk.java.net/~goetz/webrevs/8130654-mulToLen/webrev.01/
>>
>> We tested this with jck, jtreg and our benchmarks on aix, ppc64 and ppc64le.
>>
>> Best regards,
>>   Goetz.