RFR 8139203: Consistent naming for klass type predicates

[John Rose]

On Oct 27, 2015, at 2:15 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> 
> On 10/27/15 1:34 PM, John Rose wrote:
>> On Oct 27, 2015, at 10:18 AM, Coleen Phillimore <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> wrote:
>>> This is a simple renaming with 2 minor cleanups in jvm.cpp, and removed the oop functions also.
>> Nice!  And you can delete a little more:  Move the "_slow" versions into DEBUG_ONLY builds, or even kill them off.
> 
> I will move the slow versions under #ifdef ASSERT (as is assert_same_query).  I'd rather not remove them because some people I know have been eyeing the (I think) two extra bits in the layout_helper.  They could mess things up so we should leave the "slow" verification.

Good.  The layout_helper logic may also need updating to cover future exotic layouts when we start flattening heap nodes:  String+(char[]), (double+double)[].

— John