RFR: 8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp

Andrew Haley aph at redhat.com
Fri Aug 19 08:06:03 UTC 2016


On 19/08/16 01:57, David Holmes wrote:
> I've not heard anything about Aarch64 - is anyone able to test there? 
> Otherwise I need to push this as RDP1 is looming, and we can fix aarch64 
> with a follow up bug if needed.

Sorry, it wasn't flagged as affecting AArch64.

I get:

/local/aarch64/hs-comp/hotspot/src/cpu/aarch64/vm/vm_version_aarch64.hpp:92:10: error: 'ByteSize' does not name a type
   static ByteSize dczid_el0_offset() { return byte_offset_of(PsrInfo, dczid_el0); }
          ^
This is fixed easily enough by changing vm_version_aarch64.hpp so
that it #includes "utilities/sizes.hpp", like so:

#ifndef CPU_AARCH64_VM_VM_VERSION_AARCH64_HPP
#define CPU_AARCH64_VM_VM_VERSION_AARCH64_HPP

#include "runtime/globals_extension.hpp"
#include "runtime/vm_version.hpp"
#include "utilities/sizes.hpp"

After that it builds fine.  I don't know why other architectures don't
need this.

Andrew.



More information about the hotspot-dev mailing list