RFR: 8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp

[David Holmes]

On 19/08/2016 6:06 PM, Andrew Haley wrote:
> On 19/08/16 01:57, David Holmes wrote:
>> I've not heard anything about Aarch64 - is anyone able to test there?
>> Otherwise I need to push this as RDP1 is looming, and we can fix aarch64
>> with a follow up bug if needed.
>
> Sorry, it wasn't flagged as affecting AArch64.

Thanks for trying it out! How should I have flagged it? email to the 
aarch64 port alias? Or direct cc to you?

> I get:
>
> /local/aarch64/hs-comp/hotspot/src/cpu/aarch64/vm/vm_version_aarch64.hpp:92:10: error: 'ByteSize' does not name a type
>    static ByteSize dczid_el0_offset() { return byte_offset_of(PsrInfo, dczid_el0); }
>           ^
> This is fixed easily enough by changing vm_version_aarch64.hpp so
> that it #includes "utilities/sizes.hpp", like so:
>
> #ifndef CPU_AARCH64_VM_VM_VERSION_AARCH64_HPP
> #define CPU_AARCH64_VM_VM_VERSION_AARCH64_HPP
>
> #include "runtime/globals_extension.hpp"
> #include "runtime/vm_version.hpp"
> #include "utilities/sizes.hpp"

Fixed - webrev updated in place.

> After that it builds fine.  I don't know why other architectures don't
> need this.

Only vm_version_x86.hpp also uses ByteSize, but why it doesn't need the 
include I can not say. Looking at where sizes.hpp is included the only 
reason I can give is being due to precompiled.hpp, but that shouldn't be 
used on Solaris so I'm at a loss to explain it.

Thanks,
David

> Andrew.
>