RFR(s): 8148945: JDK-8148481: Devirtualize Klass::vtable breaks Zero build

Severin Gehwolf sgehwolf at redhat.com
Wed Feb 3 12:35:14 UTC 2016


Hi,

On Wed, 2016-02-03 at 13:18 +0100, Mikael Gerdin wrote:
> Hi Severin,
> 
> On 2016-02-03 12:31, Severin Gehwolf wrote:
> > Hi,
> > 
> > Could somebody please review and sponsor this Zero build fix?
> > 
> > JDK-8148481 made start_of_vtable() protected and this change accounts
> > for that by now using the new method_at_vtable() function. I
> > think src/share/vm/interpreter/bytecodeInterpreter.cpp is Zero-only
> > these days even though it lives in shared code.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8148945
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8148945/webrev.01/
> 
> Sorry for breaking this, I completely forgot about zero :(

No harm done :)

> The fix looks good to me.

Thanks! Is this enough as far as Reviewers are concerned for this
trivial fix? I'm attaching the hg-exported changeset in any case :)

Cheers,
Severin

> /Mikael
> 
> > 
> > Testing done: Zero builds again in all variants.
> > 
> > Thanks,
> > Severin
> > 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: JDK-8148945.export.patch
Type: text/x-patch
Size: 2398 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20160203/cb1d83af/JDK-8148945.export-0001.patch>


More information about the hotspot-dev mailing list