RFR(s): 8148945: JDK-8148481: Devirtualize Klass::vtable breaks Zero build

Coleen Phillimore coleen.phillimore at oracle.com
Wed Feb 3 13:10:42 UTC 2016



It looks good and is enough reviewers, so don't fix the export for me.
Mikael you can just push this change directly since JPRT doesn't build Zero.

Coleen


On 2/3/16 7:35 AM, Severin Gehwolf wrote:
> Hi,
>
> On Wed, 2016-02-03 at 13:18 +0100, Mikael Gerdin wrote:
>> Hi Severin,
>>
>> On 2016-02-03 12:31, Severin Gehwolf wrote:
>>> Hi,
>>>
>>> Could somebody please review and sponsor this Zero build fix?
>>>
>>> JDK-8148481 made start_of_vtable() protected and this change accounts
>>> for that by now using the new method_at_vtable() function. I
>>> think src/share/vm/interpreter/bytecodeInterpreter.cpp is Zero-only
>>> these days even though it lives in shared code.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8148945
>>> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8148945/webrev.01/
>> Sorry for breaking this, I completely forgot about zero :(
> No harm done :)
>
>> The fix looks good to me.
> Thanks! Is this enough as far as Reviewers are concerned for this
> trivial fix? I'm attaching the hg-exported changeset in any case :)
>
> Cheers,
> Severin
>
>> /Mikael
>>
>>> Testing done: Zero builds again in all variants.
>>>
>>> Thanks,
>>> Severin
>>>



More information about the hotspot-dev mailing list