[9] RFR (S): 8149141: Optimized build is broken

[Kim Barrett]

> On Feb 5, 2016, at 12:37 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~vlivanov/8149141/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8149141
> 
> !defined(PRODUCT) & ASSERT confusion.
> 
> Best regards,
> Vladimir Ivanov
> 
> PS: I'm surprised that unit tests are full of asserts, but guarded by !defined(PRODUCT). Any reason to keep the tests in optimized build?

Change looks good.

Not sure it’s worth cleaning up the confusion in the internal VM tests around those flags, since we’re
hoping for a better unit test framework soonish (JDK-8047975).  I’m pretty sure there are other places
where there is confusion around !defined(PRODUCT) && !defined(ASSERT), though it would help if
I could find a clear description of what “optimized” builds are for.  That variant seems to be the one
nobody talks about…