RFR(s): 8148219: Add decorator hostname to UL

David Holmes david.holmes at oracle.com
Mon Feb 15 10:42:34 UTC 2016


On 15/02/2016 8:04 PM, Robbin Ehn wrote:
> Hi, please review this v2.
>
> Update according David's comments, except os::get_host_name which needs
> to be moved from private scope.
>
> New webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8148219.v2/

All looks good.

> And manually re-tested.

Is there a test for UL that can be enhanced to test this new decorator?

Thanks,
David

> Thanks!
>
> /Robbin
>
> On 02/12/2016 01:16 PM, Robbin Ehn wrote:
>> Hi, please review.
>>
>> This adds a new decorator for hostname to UL, with minor changes to
>> os::get_host_name and UL init.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8148219
>> Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8148219/
>>
>> Manual tested and verified no change to hs_err_pid (uses
>> os::get_host_name when fastdebug build) and that UL prints hostname.
>>
>> Thanks!
>>
>> /Robbin


More information about the hotspot-dev mailing list