RFR(s): 8148219: Add decorator hostname to UL

[Marcus Larsson]

Hi,

On 02/15/2016 11:42 AM, David Holmes wrote:
> On 15/02/2016 8:04 PM, Robbin Ehn wrote:
>> Hi, please review this v2.
>>
>> Update according David's comments, except os::get_host_name which needs
>> to be moved from private scope.
>>
>> New webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8148219.v2/
>
> All looks good.

Looks good to me too.

>
>> And manually re-tested.
>
> Is there a test for UL that can be enhanced to test this new decorator?

There are unit tests for all current decorators in UL, but they are 
written in gtest and haven't been checked in yet. I suggest that we add 
a test case for this decorator when we integrate the rest of the unit tests.

Thanks,
Marcus

>
> Thanks,
> David
>
>> Thanks!
>>
>> /Robbin
>>
>> On 02/12/2016 01:16 PM, Robbin Ehn wrote:
>>> Hi, please review.
>>>
>>> This adds a new decorator for hostname to UL, with minor changes to
>>> os::get_host_name and UL init.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8148219
>>> Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8148219/
>>>
>>> Manual tested and verified no change to hs_err_pid (uses
>>> os::get_host_name when fastdebug build) and that UL prints hostname.
>>>
>>> Thanks!
>>>
>>> /Robbin