RFR: JDK-8160350 cannot truss jdk9 [solaris]

[Daniel D. Daugherty]

On 7/6/16 8:30 AM, Coleen Phillimore wrote:
>
> I uploaded it here:
>
> http://cr.openjdk.java.net/~coleenp/JDK-8160350.02/index.html

src/os/solaris/vm/os_solaris.cpp
     L1322: bool os::supports_vtime() { return true; }
     L1323: bool os::enable_vtime() { return false; }
     L1324: bool os::vtime_enabled() { return false; }

         Seems like supports_vtime() should return 'false'.
         If there is a reason that it shouldn't, then we
         need a comment.

Thumbs up modulo changing the return of supports_vtime()
or adding a comment. I don't need to see a new webrev.

Dan


>
> Coleen
>
> On 7/6/16 9:15 AM, Alan Burlison wrote:
>> On 01/07/2016 21:40, Kim Barrett wrote:
>>
>>>> Vote: Use JDK-8160350 to fix Solaris and file a new bug for the
>>>>     larger cross-platform issues.
>>>>
>>>> Dan
>>>
>>> That seems like the right approach to me as well.
>>
>> I've logged https://bugs.openjdk.java.net/browse/JDK-8160887 and 
>> linked it to JDK-8160350. For JDK-8160350 I have rolled back to 
>> version 1 of the patch which just fixes the Solaris truss issue and 
>> have prepared a new webrev which I'll get uploaded shortly. I've also 
>> run it through the hotspot testset, all tests pass.
>>
>