RFR(M): PPC64: improve array copy stubs by using vector instructions

Gustavo Romero gromero at linux.vnet.ibm.com
Tue May 24 13:59:58 UTC 2016


Hi Goetz

I'm happy to be contributing to the ppc port!

Sorry, I didn't realize that bugID was missing in the subject. Next time
I'll pay attention on that and also address the RFR to everybody, sure.
Thanks for point that out.

Thanks a lot for reviewing the change.

Best regards,
Gustavo

On 24-05-2016 05:29, Lindenmaier, Goetz wrote:
> Hi Gustavo, 
> 
> thanks for contributing this optimization to the ppc port!
> 
> The change looks good, nice work.
> 
> Next time, please use correct subject in the RFR mail, the bugID is missing.
> Also, address the RFR to everybody.  This one you addressed to Martin.
> In general, you need several reviews.
> Martin, thanks for reviewing though!
> 
> Martin, I think you can push this as it's ppc-only.
> 
> Best regards,
>   Goetz.
> 
> 
> 
>> -----Original Message-----
>> From: Gustavo Romero [mailto:gromero at linux.vnet.ibm.com]
>> Sent: Montag, 23. Mai 2016 17:54
>> To: Doerr, Martin <martin.doerr at sap.com>; ppc-aix-port-
>> dev at openjdk.java.net; hotspot-dev at openjdk.java.net
>> Cc: Simonis, Volker <volker.simonis at sap.com>; brenohl at br.ibm.com;
>> Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
>> Subject: Re: RFR(M): PPC64: improve array copy stubs by using vector
>> instructions
>>
>> Hi Martin
>>
>> Thank you for reviewing the change.
>>
>> Best regards,
>> Gustavo
>>
>> On 23-05-2016 12:51, Doerr, Martin wrote:
>>> Hi Gustavo,
>>>
>>> thanks for implementing it and taking care of my concerns. Looks good,
>> now.
>>> I will run tests and I can sponsor it after it was reviewed.
>>>
>>> Best regards,
>>> Martin
>>>
>>> -----Original Message-----
>>> From: Gustavo Romero [mailto:gromero at linux.vnet.ibm.com]
>>> Sent: Montag, 23. Mai 2016 16:22
>>> To: Doerr, Martin <martin.doerr at sap.com>; ppc-aix-port-
>> dev at openjdk.java.net; hotspot-dev at openjdk.java.net
>>> Cc: Simonis, Volker <volker.simonis at sap.com>; brenohl at br.ibm.com
>>> Subject: RFR(M): PPC64: improve array copy stubs by using vector
>> instructions
>>>
>>> Hi Martin
>>>
>>> Could you please host and review this webrev?
>>>
>>> Summary:
>>>
>>> * Add VSR registers to be used with VSX instruction set;
>>> * Add VSX load/store instructions (lxvd2x/stxvd2x) to mass copy in
>>>   the stub for disjoint short copy in order to improve it.
>>>
>>> http://81.de.7a9f.ip4.static.sl-reverse.com./8154156/9/v4/
>>>
>>> Thank you!
>>>
>>> Best regards,
>>> Gustavo
>>>
> 



More information about the hotspot-dev mailing list