RFR(XS): 8169003: LogDecorations.iso8601_utctime_test fails if numeric locale uses ", " as separator between integer and fraction part

Marcus Larsson marcus.larsson at oracle.com
Fri Nov 4 15:16:34 UTC 2016


Thanks for fixing this.

On 2016-11-01 18:30, Kirill Zhaldybin wrote:
> Dear all,
> Could you please review this fix for 8169003?
> I changed parsing of time string so now it is not depend on LC_NUMERIC 
> locale so the test does not fail if locale where "floating point" is 
> actually a comma is set.
> WebRev: 
> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8169003/webrev.00/

ISO8601 says the decimal point can be either '.' or ',' so the test 
should accept either. You could let sscanf read out the decimal point as 
a character and just verify that it is one of the two.

In the UTC test you changed ASSERT_GT to ASSERT_EQ, which means that we 
won't accept "Z" suffixed strings. Please revert that.


> CR: https://bugs.openjdk.java.net/browse/JDK-8169003
> Thank you.
> Regards, Kirill

More information about the hotspot-dev mailing list