RFR: JDK-8157455 - Convert TestOS_test to GTest

Rachel Protacio rachel.protacio at oracle.com
Mon Oct 17 17:57:02 UTC 2016


You might add parentheses in test_quicksort.cpp lines 57/58 to make 
visual scanning slightly easier? Otherwise looks good to me.

Rachel


On 10/14/2016 12:09 PM, Jesper Wilhelmsson wrote:
> Hi,
>
> Kirill gave me some feedback offline and this is an updated version of 
> the test.
>
> It's using EXPECT instead of ASSERT to allow all test cases to be 
> executed even in the presence of failures and the test cases has been 
> renamed.
>
> I also updated the copyright date since I learned that the copyright 
> should follow the code, not the file, and we are moving older code 
> into a new file.
>
> New webrev: http://cr.openjdk.java.net/~jwilhelm/8157455/webrev.01/
>
> Thanks,
> /Jesper
>
>
> Den 25/8/16 kl. 20:46, skrev Jesper Wilhelmsson:
>> Hi,
>>
>> Please review this test conversion of the large page tests to GTest.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157455
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8157455/webrev.00/
>>
>> Thanks,
>> /Jesper



More information about the hotspot-dev mailing list