RFR: JDK-8157455 - Convert TestOS_test to GTest
Jesper Wilhelmsson
jesper.wilhelmsson at oracle.com
Wed Oct 19 10:32:09 UTC 2016
Thanks Rachel!
I've added the parentheses.
I managed to mix up the bugIDs and sent the last mail in reply to the wrong
GTest conversion thread. The webrev.01 linked to below was for the QuickSort
test conversion covered in this thread:
http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-August/024356.html
I have moved the webrev to the right place:
http://cr.openjdk.java.net/~jwilhelm/8156800/webrev.01/
Please reply to any QuickSort issues in the October part of the QuickSort thread:
http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-October/024949.html
The TestOS_test originally covered in this thread is already reviewed and ready
to push.
Sorry for the mess!
/Jesper
Den 17/10/16 kl. 19:57, skrev Rachel Protacio:
> You might add parentheses in test_quicksort.cpp lines 57/58 to make visual
> scanning slightly easier? Otherwise looks good to me.
>
> Rachel
>
>
> On 10/14/2016 12:09 PM, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> Kirill gave me some feedback offline and this is an updated version of the test.
>>
>> It's using EXPECT instead of ASSERT to allow all test cases to be executed
>> even in the presence of failures and the test cases has been renamed.
>>
>> I also updated the copyright date since I learned that the copyright should
>> follow the code, not the file, and we are moving older code into a new file.
>>
>> New webrev: http://cr.openjdk.java.net/~jwilhelm/8157455/webrev.01/
>>
>> Thanks,
>> /Jesper
>>
>>
>> Den 25/8/16 kl. 20:46, skrev Jesper Wilhelmsson:
>>> Hi,
>>>
>>> Please review this test conversion of the large page tests to GTest.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157455
>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8157455/webrev.00/
>>>
>>> Thanks,
>>> /Jesper
>
More information about the hotspot-dev
mailing list