RFR(XS): 8168086: 8166869 broke jvmci build on aarch64

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Mon Oct 17 22:53:01 UTC 2016


Hi,

I would have approved this change anyway, but I just sent out the notification 
that hs is open for pushes again so now you don't have to wait for me :)

Thanks,
/Jesper

Den 17/10/16 kl. 19:27, skrev Vladimir Kozlov:
> Okay, lets wait Jesper's approval.
>
> Vladimir
>
> On 10/17/16 10:06 AM, Daniel D. Daugherty wrote:
>> So this is an AARCH64 specific change and I'm good with this change
>> going in, but I'm not Jesper.
>>
>> I've re-read Jesper's internal email about allowing urgent changes
>> to be pushed and it certainly sounds like he wants to approve the
>> urgent changes on a case-by-case basis.
>>
>> I recommend waiting until you hear from Jesper, but that's just
>> my opinion.
>>
>> Dan
>>
>>
>> On 10/17/16 10:34 AM, Vladimir Kozlov wrote:
>>> Changes does not affect code which we test. But RH can't build their
>>> aarch64 port - they need to resolve it ASAP. Jesper said that we can
>>> push urgent changes.
>>>
>>> Vladimir
>>>
>>> On 10/17/16 9:30 AM, Daniel D. Daugherty wrote:
>>>> Jesper (as the JDK9-hs GK) needs to agree to this push since
>>>> JDK9-hs is currently closed.
>>>>
>>>> Dan
>>>>
>>>>
>>>> On 10/17/16 10:16 AM, Vladimir Kozlov wrote:
>>>>> Looks good.
>>>>>
>>>>> Please, push it into jdk9/hs since hs-comp is closed and RO from now
>>>>> on.
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 10/17/16 8:58 AM, Roland Westrelin wrote:
>>>>>>
>>>>>> 8166869 was missing a similar aarch64 change which, I suppose, is
>>>>>> something like this:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~roland/8168086/webrev.00/
>>>>>>
>>>>>> Roland.
>>>>>>
>>>>
>>


More information about the hotspot-dev mailing list