RFR: JDK-8164002: Add a new CPU family (S_family) for SPARC S7 and above processors

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Oct 19 17:04:01 UTC 2016


Ignore my comment. The CPU name check now is done in 
vm_version_sparc.cpp and you correctly fixed it.

Reviewed. I will sponsor it.

Thanks,
Vladimir

On 10/19/16 10:00 AM, Vladimir Kozlov wrote:
> Hi Martin,
>
> Changes are incomplete. The code which set S_family flag is not there.
> It should be in vm_version_solaris_sparc.cpp.
>
> Thanks,
> Vladimir
>
> On 10/19/16 1:30 AM, Martin Walsh wrote:
>> Could I get a review for the following bug please:
>>
>> JDK-8164002: Add a new CPU family (S_family) for SPARC S7 and above
>> processors
>>
>> https://bugs.openjdk.java.net/browse/JDK-8164002
>>
>> Webrev is available here:
>>
>> http://cr.openjdk.java.net/~mwalsh/JDK-8164004/
>>
>>
>> The changes add support for the SPARC-S processors, meaning the correct
>> performance optimizations are made.
>>
>>
>> Thanks,
>>
>> Martin


More information about the hotspot-dev mailing list