RFR: JEP draft for Linux/s3990x port

Thu Oct 27 07:37:21 UTC 2016

Vladimir,

thanks a lot for your great help!
Bringing the s390x port into jdk9 in time wouldn't have been possible
without your support.

Regards,
The SAP JVM Team

On Thu, Oct 27, 2016 at 6:27 AM, Vladimir Kozlov
<vladimir.kozlov at oracle.com> wrote:
> JEP is Targeted and RFEs are approved.
>
> I pushed 3 Hotspot changes which have touch shared code.
> I left for you "JDK-8167673 [s390] The s390 port." because it has only s390
> specific code.
>
> Regards,
> Vladimir
>
>
> On 10/13/16 9:22 AM, Lindenmaier, Goetz wrote:
>>
>> Hi Vladimir,
>>
>> I made a new webrev containing all outstanding changes merged into one
>> patch
>> http://cr.openjdk.java.net/~goetz/wr16/8166730-linuxs390-all/hotspot.wr01/
>>
>> You probably saw my RFR with the s390 files.
>>
>> Best regards,
>>    Goetz.
>>
>>> -----Original Message-----
>>> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
>>> Sent: Thursday, October 13, 2016 1:09 AM
>>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Volker Simonis
>>> <volker.simonis at gmail.com>
>>> Cc: s390x-port-dev at openjdk.java.net; porters-dev at openjdk.java.net; build-
>>> dev <build-dev at openjdk.java.net>; HotSpot Open Source Developers
>>> <hotspot-dev at openjdk.java.net>; Java Core Libs <core-libs-
>>> dev at openjdk.java.net>
>>> Subject: Re: RFR: JEP draft for Linux/s3990x port
>>>
>>> Hi Goetz and Volker,
>>>
>>> Positive news is that JEP status is moving, changes are reviewed and some
>>> changes were already pushed.
>>>
>>> But because of our testing issues during past week I was not able to
>>> execute
>>> the testing.
>>>
>>> We hope jdk9/hs will be open soon but we want to sync jdk9/dev and merge
>>> hs-comp repository first. hs/ repo will be
>>> opened for other pushes soon after that.
>>>
>>> I added estimated integration date to the JEP (Oct 28). We would like to
>>> test
>>> and integrate this port before JDK 10
>>> forest is forked. Do you think all s390 changes and new code will be
>>> ready by
>>> that date?
>>>
>>> Do you have all shared changes reviewed and approved for push?
>>>
>>> Goetz, I saw you updated RFEs with latest webrevs. Can you again prepare
>>> changeset based on hs/ repo for changes which
>>> are not pushed yet? I will try to submit testing over weekend.
>>>
>>> Regards,
>>> Vladimir
>>>
>>> On 10/4/16 9:48 AM, Lindenmaier, Goetz wrote:
>>>>
>>>> Hi Vladimir,
>>>>
>>>> This webrev contains all the changes to hotspot needed for the port:
>>>> http://cr.openjdk.java.net/~goetz/wr16/8166730-linuxs390-
>>>
>>> all/hotspot.wr01/
>>>>
>>>>
>>>> It includes
>>>> http://cr.openjdk.java.net/~goetz/wr16/8166560-
>>>
>>> basic_s390/hotspot.wr03/
>>>>
>>>> http://cr.openjdk.java.net/~goetz/wr16/8166561-
>>>
>>> basic_C1C2_s390/webrev.01/
>>>>
>>>> http://cr.openjdk.java.net/~goetz/wr16/8166562-
>>>
>>> scratch_emit/webrev.01/
>>>>
>>>> which are out for review. Further it includes
>>>> the one change to relocate the pc-relative instructions where we didn't
>>>
>>> open
>>>>
>>>> a bug for yet, and the new s390-files.
>>>>
>>>> Altogether this passed all our tests that were running on the weekend
>>>> on linuxs390.
>>>>
>>>> The s390-files though are not yet fully in shape, I'm still editing them
>>>> to get
>>>> rid of legacy stuff and SAP JVM specific code.  E.g. all the code
>>>> guarded by
>>>> #ifdef SAPJVM  will go away in the end.
>>>>
>>>> I hope to have the final versions by end of this week.
>>>>
>>>> Best regards,
>>>>    Goetz.
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: s390x-port-dev [mailto:s390x-port-dev-bounces at openjdk.java.net]
>>>>> On Behalf Of Vladimir Kozlov
>>>>> Sent: Montag, 3. Oktober 2016 23:50
>>>>> To: Volker Simonis <volker.simonis at gmail.com>
>>>>> Cc: s390x-port-dev at openjdk.java.net; porters-dev at openjdk.java.net;
>>>>> build-dev <build-dev at openjdk.java.net>; HotSpot Open Source
>>>
>>> Developers
>>>>>
>>>>> <hotspot-dev at openjdk.java.net>; Java Core Libs <core-libs-
>>>>> dev at openjdk.java.net>
>>>>> Subject: Re: RFR: JEP draft for Linux/s3990x port
>>>>>
>>>>> Hi Volker,
>>>>>
>>>>> Can you prepare combined patch (or set of patches) based on latest
>>>>> reviews together with s390 code as it will be in final push?
>>>>>
>>>>> We want to run it through our pre-integration testing to verify that it
>>>>> does not have problems.
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 9/29/16 11:25 AM, Vladimir Kozlov wrote:
>>>>>>
>>>>>> You need to wait when Mark (OpenJDK Lead) move it to Candidate (or
>>>>>> other) state:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~mr/jep/jep-2.0-02.html
>>>>>>
>>>>>> Vladimir
>>>>>>
>>>>>> On 9/29/16 9:55 AM, Volker Simonis wrote:
>>>>>>>
>>>>>>> Hi Vladimir,
>>>>>>>
>>>>>>> thanks a lot for reviewing and endorsing the JEP.
>>>>>>>
>>>>>>> I've linked all the relevant issues to the JEP  (they all have a link
>>>>>>> to a webrev) and change the state to "Submitted".
>>>>>>>
>>>>>>> There's just one more small shared change we need for the port for
>>>>>>> which we haven't opened a bug now because we are still working on
>>>>>>> simplifying it. The current version looks as follows:
>>>>>>>
>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/2016/s390x/9000016-
>>>>>
>>>>> constant_table_offset.patch
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> What are the next steps? Should I add a "jdk9-fc-request" label to t
>>>>>>> he JEP and add a corresponding "FC Extension Request" comment to it?
>>>>>>> Or will this be done automatically once I move it to "Candidate"?
>>>>>>>
>>>>>>> Is there anything left to do before I can move it to "Candidate"
>>>>>>> state?
>>>>>>>
>>>>>>> Thanks a lot and best regards,
>>>>>>> Volker
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Sep 27, 2016 at 8:15 PM, Vladimir Kozlov
>>>>>>> <vladimir.kozlov at oracle.com> wrote:
>>>>>>>>
>>>>>>>> On 9/27/16 10:49 AM, Volker Simonis wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> can you please review and endorse the following draft JEP for the
>>>>>>>>> integration of the Linux/s390x port into the jkd9 master
>>>>>>>>> repository:
>>>>>>>>>
>>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8166730
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Good.
>>>>>>>> Add links to webrevs in a comment. It will help to get umbrella FC
>>>>>>>> extension
>>>>>>>> approval.
>>>>>>>>
>>>>>>>>>
>>>>>>>>> As detailed in the JEP, the Linux/s390x requires very few shared
>>>>>>>>> changes and we therefore don't foresee any impact on the existing
>>>>>>>>> platforms at all. Following you can find a short description of the
>>>>>>>>> planned changes:
>>>>>>>>>
>>>>>>>>> hotspot:
>>>>>>>>> =======
>>>>>>>>>
>>>>>>>>> Out for review:
>>>>>>>>> 8166560: [s390] Basic enablement of s390 port.
>>>>>>>>> http://cr.openjdk.java.net/~goetz/wr16/8166560-
>>>>>
>>>>> basic_s390/hotspot.wr01/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Reviewed:
>>>>>>>>> 8166562: C2: Suppress relocations in scratch emit.
>>>>>>>>> http://cr.openjdk.java.net/~goetz/wr16/8166562-
>>>>>
>>>>> scratch_emit/webrev.01/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Will send RFR soon (depends on 8166560):
>>>>>>>>> 8166561: [s390] Adaptions needed for s390 port in C1 and C2.
>>>>>>>>> http://cr.openjdk.java.net/~goetz/wr16/8166562-
>>>>>
>>>>> scratch_emit/webrev.01
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Wrong link.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Vladimir
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> We are still investigating the need of these shared changes:
>>>>>>>>>
>>>>>>>>>
>>>>>
>>> http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000
>>>>>
>>>>> 011-pass_PC_to_retAddrOffset.patch
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>
>>> http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000
>>>>>
>>>>> 016-constant_table_offset.patch
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> And finally the patch with the s390x-only platform files. We are
>>>>>>>>> still
>>>>>>>>> editing these to get them into OpenJdk style and shape.
>>>>>>>>> Hotspot passes most jck, jtreg and spec tests with these.
>>>>>>>>>
>>>>>>>>>
>>>>>
>>> http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000
>>>>>
>>>>> 101-zFiles.patch
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> top-level repository:
>>>>>>>>> ===============
>>>>>>>>>
>>>>>>>>> The following is just adding some s390x specific compiler flags to
>>>>>>>>> flags.m4
>>>>>>>>> 8166800: [s390] Top-level build changes required for Linux/s390x
>>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8166800
>>>>>>>>>
>>>>>>>>> jdk repository:
>>>>>>>>> ============
>>>>>>>>>
>>>>>>>>> This one just adds a new jvm.cfg file for s390x
>>>>>>>>> 8166801: [s390] Add jvm.cfg file for Linux/s390x
>>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8166801
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> And finally we plan to do one more change which fixes the jtreg
>>>>>>>>> test
>>>>>>>>> on Linux/s390x. But this is mainly for the correct detection of the
>>>>>>>>> platform and for excluding the tests which are not appropriate for
>>>>>>>>> s390x.
>>>>>>>>>
>>>>>>>>> Thank you and best regards,
>>>>>>>>> Volker
>>>>>>>>>
>>>>>>>>
>