Request for review (s) - 8155948: Add message for CMS deprecation for some internal builds
Kim Barrett
kim.barrett at oracle.com
Fri Sep 23 22:33:41 UTC 2016
> On Sep 23, 2016, at 2:25 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>
> After some discussion I've removed the handling of the
> UseAutoGCSelectPolicy flag from this patch. It will be handled
> separately under
>
> https://bugs.openjdk.java.net/browse/JDK-8166461
>
>
> The new full webrev is
>
> http://cr.openjdk.java.net/~jmasa/8155948/webrev.04/
>
> The delta is
>
> http://cr.openjdk.java.net/~jmasa/8155948/webrev_delta.03_04/index.html
>
> Thanks.
>
> Jon
------------------------------------------------------------------------------
src/share/vm/runtime/arguments.cpp
I think this line should not be removed:
1807 handle_extra_cms_flags("UseAutoGCSelectPolicy uses UseConcMarkSweepGC");
Removal of this line means that commercial builds that otherwise warn
about CMS being deprecated when it is selected won't warn if it is
selected via this mechanism.
Similarly for the test.
So I liked the previous version and not so much this one.
------------------------------------------------------------------------------
More information about the hotspot-dev
mailing list