Request for review (s) - 8155948: Add message for CMS deprecation for some internal builds
Jon Masamitsu
jon.masamitsu at oracle.com
Mon Sep 26 21:18:08 UTC 2016
Kim,
I thought that upshot of the discussion earlier in the week was that
the UseAutoGCSelectPolicy flag should be deprecated itself and
so would circumvent the warning about CMS being deprecated if
UseAutoGCSelectPolicy picked CMS. Dima's point was that GC
ergonomics should not pick a collector that was deprecated.
Not so?
Jon
On 9/23/2016 3:33 PM, Kim Barrett wrote:
>> On Sep 23, 2016, at 2:25 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>>
>> After some discussion I've removed the handling of the
>> UseAutoGCSelectPolicy flag from this patch. It will be handled
>> separately under
>>
>> https://bugs.openjdk.java.net/browse/JDK-8166461
>>
>>
>> The new full webrev is
>>
>> http://cr.openjdk.java.net/~jmasa/8155948/webrev.04/
>>
>> The delta is
>>
>> http://cr.openjdk.java.net/~jmasa/8155948/webrev_delta.03_04/index.html
>>
>> Thanks.
>>
>> Jon
> ------------------------------------------------------------------------------
> src/share/vm/runtime/arguments.cpp
>
> I think this line should not be removed:
>
> 1807 handle_extra_cms_flags("UseAutoGCSelectPolicy uses UseConcMarkSweepGC");
>
> Removal of this line means that commercial builds that otherwise warn
> about CMS being deprecated when it is selected won't warn if it is
> selected via this mechanism.
>
> Similarly for the test.
>
> So I liked the previous version and not so much this one.
>
> ------------------------------------------------------------------------------
>
More information about the hotspot-dev
mailing list