[RFH]: 8186443: Missing stdint.h for zero builds
David Holmes
david.holmes at oracle.com
Tue Aug 22 00:29:28 UTC 2017
On 21/08/2017 7:18 PM, John Paul Adrian Glaubitz wrote:
> On 08/21/2017 11:06 AM, John Paul Adrian Glaubitz wrote:
>> Ok. I still have split up the changes into two patches because otherwise
>> I frankly wouldn't know how to squeeze the information about both changes
>> into a single commit message.
>
> I even managed now to use webrev [1] ;-).
>
> Adrian
>
>> [1] http://cr.openjdk.java.net/~glaubitz/8186443/webrev.00/
Looks good. Couple of nits
test/native/runtime/test_vmStructs.cpp
Copyright notice needs updating: "2016," -> "2016, 2017,"
Please add blank line between these lines:
29 #include "runtime/vmStructs.hpp"
30 TEST(VMStructs, last_entries) {
---
src/share/vm/runtime/vmStructs.hpp
Please update copyright final year to 2017.
---
The commit message format is described here:
http://openjdk.java.net/guide/producingChangeset.html
In this case:
8186443: Missing stdint.h for zero builds
Reviewed-by: kbarratt, dholmes
If you make changes, commit and regen webrev I'll grab it from there and
sponsor for you.
Thanks,
David
More information about the hotspot-dev
mailing list