[RFH]: 8186443: Missing stdint.h for zero builds

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Tue Aug 22 00:32:09 UTC 2017


Hi David!

On 08/22/2017 02:29 AM, David Holmes wrote:
> Looks good. Couple of nits

Thanks for the review!

> test/native/runtime/test_vmStructs.cpp
> 
> Copyright notice needs updating: "2016," -> "2016, 2017,"

Makes sense :-).

> Please add blank line between these lines:
> 
>   29 #include "runtime/vmStructs.hpp"
>   30 TEST(VMStructs, last_entries)  {

Ok. I agree, it improves the readability.

> ---
> 
> src/share/vm/runtime/vmStructs.hpp
> 
> Please update copyright final year to 2017.

Ack.

> ---
> 
> The commit message format is described here:
> 
> http://openjdk.java.net/guide/producingChangeset.html
> 
> In this case:
> 
> 8186443: Missing stdint.h for zero builds
> Reviewed-by: kbarratt, dholmes

Ok. So just squash both changes into one commit?

> If you make changes, commit and regen webrev I'll grab it from there and sponsor for you.

Great. Thank you!

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


More information about the hotspot-dev mailing list