[RFH]: 8186443: Missing stdint.h for zero builds

[David Holmes]

On 22/08/2017 10:32 AM, John Paul Adrian Glaubitz wrote:
> Hi David!
> 
> On 08/22/2017 02:29 AM, David Holmes wrote:
>> Looks good. Couple of nits
> 
> Thanks for the review!
> 
>> test/native/runtime/test_vmStructs.cpp
>>
>> Copyright notice needs updating: "2016," -> "2016, 2017,"
> 
> Makes sense :-).
> 
>> Please add blank line between these lines:
>>
>>    29 #include "runtime/vmStructs.hpp"
>>    30 TEST(VMStructs, last_entries)  {
> 
> Ok. I agree, it improves the readability.
> 
>> ---
>>
>> src/share/vm/runtime/vmStructs.hpp
>>
>> Please update copyright final year to 2017.
> 
> Ack.
> 
>> ---
>>
>> The commit message format is described here:
>>
>> http://openjdk.java.net/guide/producingChangeset.html
>>
>> In this case:
>>
>> 8186443: Missing stdint.h for zero builds
>> Reviewed-by: kbarratt, dholmes
> 
> Ok. So just squash both changes into one commit?

Yes. You can only have one changeset per bugID per repo.

Thanks,
David

>> If you make changes, commit and regen webrev I'll grab it from there and sponsor for you.
> 
> Great. Thank you!
> 
> Adrian
>