[RFR]: 8186655: Identifier strings for PowerPC 64 LE and PowerPC 64 are swapped

Thomas Stüfe thomas.stuefe at gmail.com
Wed Aug 23 09:49:52 UTC 2017


Hi John,

Looks fine. Thanks for fixing.

Best Regards, Thomas

On Wed, Aug 23, 2017 at 11:19 AM, John Paul Adrian Glaubitz <
glaubitz at physik.fu-berlin.de> wrote:

> Hi!
>
> While working on hotspot/src/os/linux/vm/os_linux.cpp to add new
> architectures for Zero,
> I noticed that the identifier strings for PowerPC 64 and PowerPC 64 LE are
> swapped:
>
> #if defined(VM_LITTLE_ENDIAN)
>     {EM_PPC64, EM_PPC64, ELFCLASS64, ELFDATA2LSB, (char*)"Power PC 64"},
> #else
>     {EM_PPC64, EM_PPC64, ELFCLASS64, ELFDATA2MSB, (char*)"Power PC 64 LE"},
> #endif
>
> The upper entry should have the string "PowerPC 64 LE" and the lower one
> "PowerPC 64", not vice versa.
>
> I already whipped up a patch and pushed the changeset to [1].
>
> Thanks,
> Adrian
>
> [1] http://cr.openjdk.java.net/~glaubitz/8186655/webrev.00/
>>
>
> --
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz at debian.org
> `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
>


More information about the hotspot-dev mailing list