[RFR]: 8186655: Identifier strings for PowerPC 64 LE and PowerPC 64 are swapped

David Holmes david.holmes at oracle.com
Wed Aug 23 12:35:33 UTC 2017


Looks good. I will sponsor this for you tomorrow.

Thanks,
David

On 23/08/2017 7:19 PM, John Paul Adrian Glaubitz wrote:
> Hi!
> 
> While working on hotspot/src/os/linux/vm/os_linux.cpp to add new 
> architectures for Zero,
> I noticed that the identifier strings for PowerPC 64 and PowerPC 64 LE 
> are swapped:
> 
> #if defined(VM_LITTLE_ENDIAN)
>      {EM_PPC64, EM_PPC64, ELFCLASS64, ELFDATA2LSB, (char*)"Power PC 64"},
> #else
>      {EM_PPC64, EM_PPC64, ELFCLASS64, ELFDATA2MSB, (char*)"Power PC 64 
> LE"},
> #endif
> 
> The upper entry should have the string "PowerPC 64 LE" and the lower one 
> "PowerPC 64", not vice versa.
> 
> I already whipped up a patch and pushed the changeset to [1].
> 
> Thanks,
> Adrian
> 
>> [1] http://cr.openjdk.java.net/~glaubitz/8186655/webrev.00/
> 


More information about the hotspot-dev mailing list