RFR: 8168914: Crash in ClassLoaderData/JNIHandleBlock::oops_do during concurrent marking

Thomas Schatzl thomas.schatzl at oracle.com
Wed Feb 22 08:35:16 UTC 2017


Hi Erik,

On Tue, 2017-02-21 at 11:19 -0500, Kim Barrett wrote:
> > 
> > On Feb 21, 2017, at 10:49 AM, Erik Helin <erik.helin at oracle.com>
> > wrote:
> > 
> > David, Kim, please see new patches at:
> > - inc: http://cr.openjdk.java.net/~ehelin/8168914/03-04/
> > - full: http://cr.openjdk.java.net/~ehelin/8168914/04/
> > 
> > Thanks,
> > Erik
> -------------------------------------------------------------------
> -----------
> src/share/vm/classfile/classLoaderData.cpp
>  144   Chunk* head = (Chunk*) OrderAccess::load_ptr_acquire((volatile
> intptr_t*)&_head);
> 
> Still has unnecessary cast of &_head,
> 
> -------------------------------------------------------------------
> -----------
> src/share/vm/classfile/classLoaderData.hpp
>  186     void oops_do_chunk(OopClosure* f, Chunk* c, const juint
> size);
> 
> oops_do_chunk ahould be private.
> 
> -------------------------------------------------------------------
> -----------
> 
> I don't need a new webrev for these.
> 

  same here.

Thanks,
  Thomas



More information about the hotspot-dev mailing list