RFR: 8178499: Remove _ptr_ and _size_ infixes from align functions

[Thomas Schatzl]

Hi,

On Tue, 2017-07-04 at 13:56 +0200, Thomas Schatzl wrote:
> Hi Stefan,
> 
> On Fri, 2017-06-30 at 11:40 +0200, Stefan Karlsson wrote:
> > 
> > Hi all,
> > 
> > Please review this patch to remove the _ptr_ and _size_ infixes
> > from 
> > align functions.
> > 
> > http://cr.openjdk.java.net/~stefank/8178499/webrev.00
> > http://bugs.openjdk.java.net/browse/JDK-8178499
> > 
> > Rename functions (and corresponding macros) from:
> >   align_ptr_up
> >   align_size_up
> >   align_ptr_down
> >   align_size_down
> >   is_ptr_aligned
> >   is_size_aligned
> > 
> > to:
> >   align_up
> >   align_down
> >   is_aligned
> > 
> > The patch builds upon the changes in:
> >   http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-
> > June/027328.html
> > 
>   looks good. I am not sure if I am happy about the renamings of the
> non-global align* methods, as they at least sometimes seemed to have
> been part of the item you wanted to align. E.g.
> ReservedSpace::page_align_size_* to ReservedSpace::page_align_*.
> 
> There is at least one name clash because of that is resolved using
> the "::" specifiers (in space.cpp:~670). Or maybe this can be
> resolved by different naming in ReservedSpace.
> 

  Stefan made me aware that the last statement is untrue, the name
clash has nothing to do with the renaming of ReservedSpace methods. The
new names for the changed ReservedSpace just feel worse than before,
but maybe this is not an issue for others. Feel free to ignore this
comment.

Sorry for the trouble with that,
  Thomas