RFR: 8191333: Zero variant broken after 8189941

Robbin Ehn robbin.ehn at oracle.com
Wed Nov 15 15:56:28 UTC 2017


Hi looks good, but:

101 #define SAFEPOINT 
       \
  102     if ( SafepointSynchronize::is_synchronizing()) { 
         \
  103         { 
         \

You should not need to call SafepointSynchronize::is_synchronizing().
SafepointMechanism::block_if_requested(THREAD) takes care of everything.
And if you ever plan to add thread-local handshake support to zero that won't work.

If you want push code as is, that is fine.

/Robbin


On 11/15/2017 04:07 PM, John Paul Adrian Glaubitz wrote:
> Hi!
> 
> Please review this change [1] which fixes Zero which got broken
> after 8189941 [2].
> 
> Thanks to Robbin Ehn for the quick help with this!
> 
> Adrian
> 
>> [1] http://cr.openjdk.java.net/~glaubitz/8191333/webrev.00/
>> [2] https://bugs.openjdk.java.net/browse/JDK-8191333
> 


More information about the hotspot-dev mailing list