RFR: 8200759: Move GC entries in vmStructs.cpp to GC specific files

Aleksey Shipilev shade at redhat.com
Thu Apr 5 15:09:18 UTC 2018


On 04/05/2018 01:47 PM, Stefan Karlsson wrote:
>> *) It feels awkward to move JavaThread::_satb_mark_queue and JavaThread::_dirty_card_queue, to
>> VM_STRUCTS_G1GC, since it is guarded by INCLUDE_ALL_GCS. VM_STRUCTS_GC seems more fitting. (Trivia:
>> Shenandoah uses those things too, so they are "shared", even though the implementation is indeed in
>> vm/gc/g1).
> 
> My follow-up changes change this to INCLUDE_G1GC, so in that sense this I don't think it's that
> awkward.
> 
> However, if Shenandoah needs to use this then I agree that it needs to be moved. I don't think it
> needs to be done for this change though.

Yeah, it would probably move under JDK-8154343 later.

>> #ifdef INCLUDE_CMS
>>     VM_TYPES_CMSGC(declare_type,                        \
>>                    declare_toplevel_type,               \
>>                    integer_type))                       \
>> #endif
>> #ifdef INCLUDE_G1
>>     VM_TYPES_G1GC(declare_type,                        \
>>                    declare_toplevel_type,              \
>>                    integer_type))                      \
>> #endif
> 
> I can't really use your suggested constructs, because it won't compile.

Ah, because ifdef is inside the macro. Nevermind.

-Aleksey


More information about the hotspot-dev mailing list