RFR: 8200759: Move GC entries in vmStructs.cpp to GC specific files

Stefan Karlsson stefan.karlsson at oracle.com
Fri Apr 6 08:00:31 UTC 2018


Hi all,

Since I have a few follow-up changes that depend on the ALL_GCS_ONLY 
macro introduced in this patch, I'm going to extract that part into a 
separate RFE, so that if any of the following patches need to be backed 
out (for some reason) I won't have to back out this change.

This is the piece I'm going to push separately:
http://cr.openjdk.java.net/~stefank/8200759/webrev.01/src/hotspot/share/utilities/macros.hpp.udiff.html

Thanks,
StefanK

On 2018-04-04 21:37, Stefan Karlsson wrote:
> Hi all,
> 
> Please review this patch to move GC specific entries in vmStructs.cpp 
> out to GC specific files.
> 
> http://cr.openjdk.java.net/~stefank/8200759/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8200759
> 
> This patch is done in preparation for:
>   https://bugs.openjdk.java.net/browse/JDK-8200729 - Conditional 
> compilation of GCs
> 
> This patch also has the nice feature that it removes multiple usages of 
> the GC specific defines in vmStructs.cpp. When new GCs are added only 
> three defines need to be added to vmStructs_gc.hpp.
> 
> Tested locally with test/hotspot/jtreg/serviceability/sa, but will run 
> this through mach5 to find potantial missing includes / forward 
> declarations.
> 
> Thanks,
> StefanK


More information about the hotspot-dev mailing list