[8u] RFR: 8196882: VS2017 Hotspot Defined vsnprintf Function Causes C2084 Already Defined Compilation Error

Kim Barrett kim.barrett at oracle.com
Wed Aug 1 20:17:28 UTC 2018


> On Aug 1, 2018, at 10:47 AM, Kevin Walls <kevin.walls at oracle.com> wrote:
> 
> Hi Kim,
> 
> Yes we can try that way.  I can reword the intention to be less particular about keeping old windows behaviour.
> 
> A new change is that in 8u I found g1GCPhaseTimes.cpp has a vsnprintf which was checking for -1 to mean buffer too small.

Yikes! That's a pretty bad pre-existing bug!  This code doesn't seem
to exist in later versions, having been replaced with UL.

> http://cr.openjdk.java.net/~kevinw/8196882/webrev.02/

Looks good to me.



More information about the hotspot-dev mailing list