RFR (L): 8208671: Runtime, JFR, Serviceability changes to allow enabling -Wreorder

[Harold David Seigel]

Hi Thomas,

The change looks good!  Just a few comments.

In vm_operations.hpp, there an added call to _setter() in 
VM_FindDeadlocks(outputStream* st).  Is that call needed to initialize 
_setter() properly?

    - VM_FindDeadlocks(bool concurrent_locks) :
    _concurrent_locks(concurrent_locks), _out(NULL), _deadlocks(NULL),
    _setter() {};
    - VM_FindDeadlocks(outputStream* st) : _concurrent_locks(true),
    _out(st), _deadlocks(NULL) {};
    + VM_FindDeadlocks(bool concurrent_locks) :
    _concurrent_locks(concurrent_locks), _deadlocks(NULL), _out(NULL),
    _setter() {};
    + VM_FindDeadlocks(outputStream* st) : _concurrent_locks(true),
    _deadlocks(NULL), _out(st), _setter() {};

In elfFuncDescTable.cpp, there an added call to _status(), is that call 
needed to initialize _status properly?

    - _file(file), _index(index), _section(file, shdr) {
    + _section(file, shdr), _file(file), _index(index), _status() {

Thanks, Harold

On 8/2/2018 5:09 AM, Thomas Schatzl wrote:
> Hi all,
>
>    there have been several suggestions to try to fix the Hotspot code to
> allow us to enable -Wreorder in the Hotspot sources.
> This should make problems due to use-before-initialization much more
> obvious.
>
> This change fixes initializer lists for the runtime, jfr and
> serviceability directories.
>
> There should be no change in code behavior.
>
> A later follow-up will enable -Wreorder in the makefiles.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8208671
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8208671/webrev/
> Testing:
> hs-tier1-4,jdk-tier1-3
>
> Thanks,
>    Thomas