RFR (L): 8208671: Runtime, JFR, Serviceability changes to allow enabling -Wreorder

[Thomas Schatzl]

Hi Harold,

On Thu, 2018-08-02 at 13:18 -0400, Harold David Seigel wrote:
> Hi Thomas,
> 
> The change looks good!  Just a few comments.
> 
> In vm_operations.hpp, there an added call to _setter() in 
> VM_FindDeadlocks(outputStream* st).  Is that call needed to
> initialize 
> _setter() properly?
> 
>     - VM_FindDeadlocks(bool concurrent_locks) :
>     _concurrent_locks(concurrent_locks), _out(NULL),
> _deadlocks(NULL),
>     _setter() {};
>     - VM_FindDeadlocks(outputStream* st) : _concurrent_locks(true),
>     _out(st), _deadlocks(NULL) {};
>     + VM_FindDeadlocks(bool concurrent_locks) :
>     _concurrent_locks(concurrent_locks), _deadlocks(NULL),
> _out(NULL),
>     _setter() {};
>     + VM_FindDeadlocks(outputStream* st) : _concurrent_locks(true),
>     _deadlocks(NULL), _out(st), _setter() {};
> 
> In elfFuncDescTable.cpp, there an added call to _status(), is that
> call 
> needed to initialize _status properly?
> 
>     - _file(file), _index(index), _section(file, shdr) {
>     + _section(file, shdr), _file(file), _index(index), _status() {

  the reason they are still there because I initially started to add
"missing" initialization code because I believe it is nice to have
them, but later reversed course. The compiler will automatically add
default initialization anyway, and I later felt this out of scope for
this change anyway.
I forgot to change these constructors back in these cases.

I will remove them again, they are unnecessary. Sorry.

Thanks,
  Thomas