RFR [XXS]: Tiny bug in VM monitoring/management

[Haug, Gunter]

Hi David,

Thanks for looking into this.

>  But I have to wonder if this will suddenly turn this on or 
>  off for some platform where it was off or on?? Ideally we will find both 
>  flags are normally set the same.

I don't think it's a problem. _thread_allocated_memory_enabled is always on, the VM takes care for that value regardless of the OS. _thread_cpu_time_enabled is turned on depending of the capabilities of the OS. Most systems support it, one exception is non-Apple BSD. In this case is_thread_allocated_memory_enabled() currently returns false even though it is actually supported by the VM.

Best,
Gunter

On 21.12.18, 12:02, "David Holmes" <david.holmes at oracle.com> wrote:

    Hi Gunter,
    
    On 21/12/2018 8:37 pm, Haug, Gunter wrote:
    > Hi all,
    > 
    > can I please have reviews and a sponsor fort the following change:
    > 
    > https://bugs.openjdk.java.net/browse/JDK-8215791
    > http://cr.openjdk.java.net/~ghaug/webrevs/8215791/
    > 
    > This was obviously just a copy and paste mishap.
    
    Obviously! But I have to wonder if this will suddenly turn this on or 
    off for some platform where it was off or on?? Ideally we will find both 
    flags are normally set the same.
    
    > Thanks and happy holidays,
    
    Likewise!
    
    Cheers,
    David
    
    > Gunter
    >