RFR [XXS]: Tiny bug in VM monitoring/management

[Volker Simonis]

Hi Gunter,

the change looks good to me. I can sponsor it.

On Fri, Dec 21, 2018 at 2:52 PM Haug, Gunter <gunter.haug at sap.com> wrote:
>
> Hi David,
>
> Thanks for looking into this.
>
> >  But I have to wonder if this will suddenly turn this on or
> >  off for some platform where it was off or on?? Ideally we will find both
> >  flags are normally set the same.
>
> I don't think it's a problem. _thread_allocated_memory_enabled is always on, the VM takes care for that value regardless of the OS. _thread_cpu_time_enabled is turned on depending of the capabilities of the OS. Most systems support it, one exception is non-Apple BSD. In this case is_thread_allocated_memory_enabled() currently returns false even though it is actually supported by the VM.
>

It could also (unintentionally) have been switched off on Windows if
the call to "GetThreadTimes()" in "os::is_thread_cpu_time_supported()"
has failed. But I don't think that usually happened. And anyway, as
Gunter wrote, "_thread_allocated_memory_enabled" is supported on any
system anyway. So I think it is safe to push this.

Regards,
Volker

> Best,
> Gunter
>
> On 21.12.18, 12:02, "David Holmes" <david.holmes at oracle.com> wrote:
>
>     Hi Gunter,
>
>     On 21/12/2018 8:37 pm, Haug, Gunter wrote:
>     > Hi all,
>     >
>     > can I please have reviews and a sponsor fort the following change:
>     >
>     > https://bugs.openjdk.java.net/browse/JDK-8215791
>     > http://cr.openjdk.java.net/~ghaug/webrevs/8215791/
>     >
>     > This was obviously just a copy and paste mishap.
>
>     Obviously! But I have to wonder if this will suddenly turn this on or
>     off for some platform where it was off or on?? Ideally we will find both
>     flags are normally set the same.
>
>     > Thanks and happy holidays,
>
>     Likewise!
>
>     Cheers,
>     David
>
>     > Gunter
>     >
>
>