RFR : 8197412 Enable docker container related tests for linux s390x

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Mon Feb 12 16:43:46 UTC 2018


Looks good,

Misha

On 2/9/18, 2:29 AM, Baesken, Matthias wrote:
>
> Hello, please review :
>
> 8197412 Enable docker container related tests for linux s390x
>
> This enables the docker related tests on Linux s390x.   I tested on 
> SLES12  , docker   version 17.09.1 .
>
> Some comments :
>
> TestCPUSets.java :
>
> is for now disabled on s390x   because   Cpus_allowed_list   from 
>   /proc/self/status  can give  misleading values (larger than the 
> currently available CPU number).
>
> DockerTestUtils.java :
>
>  I changed  the order to docker build  to what is really documented .
>
> Docker help build says :
>
> Usage:  docker build [OPTIONS] PATH | URL | -
>
> On older docker versions the order is important ( but on docker 17.x 
> is seems to be ok to give the path first, still prefer to change it to 
> what the help says ).
>
> Webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8197412.0/ 
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8197412.0/>
>
> bug :
>
> https://bugs.openjdk.java.net/browse/JDK-8197412
>
> Thanks, Matthias
>


More information about the hotspot-dev mailing list