RFR: 8199220: Zero build broken after 8195103 and 8191102 (was RFR: 8199220: Zero build broken)

[Erik Österlund]

Hi Thomas,

Yes your intuition is correct. The point is indeed the missing 
specialization that triggers a compilation error when the condition for 
the STATIC_ASSERT is false. So the proposed change to debug.hpp will 
make all STATIC_ASSERTs pass.

Looks like the triggered assert should be dealt with instead.

Thanks,
/Erik

On 2018-03-12 20:54, Thomas Stüfe wrote:
> Hi Edward,
>
> Thanks a lot for the fixing work!
>
> However, I am not so sure about the change to debug.hpp. Is the point 
> of the Static assert thing not The missing <false> Specialization? In 
> which case the compile error you saw there was a static assert firing...
> I may be wrong, maybe Erik could clarify?
>
> Otherwise the change looks good. Thank you.
>
> ..Thomas
>
>
> On Mon 12. Mar 2018 at 20:27, Edward Nevill <edward.nevill at gmail.com 
> <mailto:edward.nevill at gmail.com>> wrote:
>
>     On Mon, 2018-03-12 at 13:57 +1000, David Holmes wrote:
>     > Hi Ed,
>     >
>     >
>     > Once we're certain this addresses all the issues it was intended to
>     > address (ref Thomas's email) you should generate a final
>     changeset with
>     > the exact changes (ie Coleen's comment) and the final set of
>     reviewers,
>     > and post the link. I'll take that re-run through our internal
>     tests and
>     > then push.
>     >
>     >
>
>     Hi David,
>
>     Thanks for your patience. New webrev here
>
>     http://cr.openjdk.java.net/~enevill/8199220/webrev.03
>     <http://cr.openjdk.java.net/%7Eenevill/8199220/webrev.03>
>
>     I have updated the webrev to build the debug version of zero which
>     has been broken since Nov 20, 2017 by change 8189871.
>
>     https://bugs.openjdk.java.net/browse/JDK-8189871
>
>     This caused the error
>
>     /home/ed/openjdk/hs/src/hotspot/share/utilities/debug.hpp:184:29:
>     error: incomplete type ‘STATIC_ASSERT_FAILURE<false>’ used in
>     nested name specifier
>
>     I have also addressed Coleen's comment.
>
>     Build tested zero release/debug and server release/debug,
>
>     Thanks for you help,
>     Ed.
>