RFR: JDK-8202676: AArch64: Missing enter/leave around barrier leads to infinite loop

[Andrew Haley]

On 05/05/18 10:51, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/JDK-8202676/webrev.01/
> 
> Does it hurt if it's ever called from a place where enter() / leave() is
> not strictly required? I.e. if we already have an interpreter frame?

It's fine.

> Good to push?

On more thing: please add a comment at the start of
TemplateInterpreterGenerator::generate_Reference_get_entry and
BarrierSetAssembler::load_at and
G1BarrierSetAssembler::g1_write_barrier_pre like this:

// LR is live.  It must be saved around calls.

Feel free to add as many capitals as you like.

This comment might help avoid it breaking again.  You never know, it
might work.

You don't need another approval for that.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671