RFR: JDK-8202676: AArch64: Missing enter/leave around barrier leads to infinite loop

Roman Kennke rkennke at redhat.com
Sat May 5 22:53:21 UTC 2018


Am 05.05.2018 um 16:54 schrieb Andrew Haley:
> On 05/05/18 10:51, Roman Kennke wrote:
>> http://cr.openjdk.java.net/~rkennke/JDK-8202676/webrev.01/
>>
>> Does it hurt if it's ever called from a place where enter() / leave() is
>> not strictly required? I.e. if we already have an interpreter frame?
> 
> It's fine.
> 
>> Good to push?
> 
> On more thing: please add a comment at the start of
> TemplateInterpreterGenerator::generate_Reference_get_entry and
> BarrierSetAssembler::load_at and
> G1BarrierSetAssembler::g1_write_barrier_pre like this:
> 
> // LR is live.  It must be saved around calls.
> 
> Feel free to add as many capitals as you like.
> 
> This comment might help avoid it breaking again.  You never know, it
> might work.
> 
> You don't need another approval for that.
> 

Thanks for the review! Pushed as:

http://hg.openjdk.java.net/jdk/jdk/rev/7238cb613dc5

Cheers, Roman



More information about the hotspot-dev mailing list