RFR (S) 8202684: Minimal VM build is broken after JDK-8199067, JDK-8202638

David Holmes david.holmes at oracle.com
Sun May 6 07:18:30 UTC 2018


Hi Aleksey,

On 5/05/2018 8:52 PM, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8202684
> 
> Fix:
>    http://cr.openjdk.java.net/~shade/8202684/webrev.01/

While this will fix your issue I can't help but think that the 
dependency on NMT should be far more explicit and potentially handled in 
a different place. It is very unclear to me why 
share/memory/metaspace/metaspaceDCmd.cpp is intimately tied to NMT, or 
what it means to use it without NMT. ??

David
-----

> Does the same thing as we do for other tests. Plus introduces NMT-specific inline macros.
> 
> Testing: x86_64 server build, x86 minimal build, x86 server build
> 
> Thanks,
> -Aleksey
> 


More information about the hotspot-dev mailing list