8203287: Zero fails to build after JDK-8199712 (Flight Recorder)

Severin Gehwolf sgehwolf at redhat.com
Thu May 17 14:02:34 UTC 2018


On Thu, 2018-05-17 at 15:27 +0200, Aleksey Shipilev wrote:
> On 05/17/2018 03:12 PM, Severin Gehwolf wrote:
> > Hi Martin, Aleksey,
> > 
> > Since JDK-8203288 has been pushed here is the latest webrev for Zero.
> > It no longer contains changes in os_perf_linux.cpp.
> > 
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203287/webrev.02/
> > 
> > How does it look?
> 
> Looks good, but I used parentheses inconsistently with the rest of Hotspot in the original patch:
> 
>  #if (defined X86 && !defined ZERO)
> 
> Should be:
> 
>  #if defined(X86) && !defined (ZERO)

OK. Here it goes:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203287/webrev.03/

Thoughts?

Cheers,
Severin


More information about the hotspot-dev mailing list