[hs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

[Aleksey Shipilev]

On 05/15/2018 02:52 AM, David Holmes wrote:
> This review is being spread across four groups: langtools, core-libs, hotspot and serviceability.
> This is the specific review thread for hotspot - webrev:
> 
> http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.hotspot.v1/

I have not looked through the code, but built current valhalla/valhalla @ 41799b26a947 (nestmates)
with x86_32 and aarch64, and ran these tests fastdebug builds on both platforms:

  test/hotspot/jtreg/runtime/Nestmates/
    x86_32:  OK
    aarch64: OK

  test/hotspot/jtreg/runtime/SelectionResolution/
    x86_32:  OK
    aarch64: OK

  test/jdk/java/lang/instrument/RedefineNestmateAttr/
    x86_32:  OK
    aarch64: OK

  test/jdk/java/lang/invoke/
    x86_32:  OK-ish -- these failures seem to manifest without nestmates too
       java/lang/invoke/condy/CondyReturnPrimitiveTest.java

         Failed. Unexpected exit from test [exit code: 134]
       java/lang/invoke/condy/CondyWrongType.java
         Failed. Execution failed: `main' threw exception: java.lang.Exception: failures: 5
       java/lang/invoke/LFCaching/LFGarbageCollectedTest.java

         Error. Parse Exception: `@library' must appear before first action tag

    aarch64: FAILED
       java/lang/invoke/SpecialInterfaceCall.java
          http://cr.openjdk.java.net/~shade/nestmates/SpecialInterfaceCall-hs_err.log

I have not dug deeper yet, AArch64 maintainers are welcome to step in!

Thanks,
-Aleksey

P.S. It would be convenient to have a way to run all the tests that the particular feature had
affected. Probably adding @bug with parent JBS ID would be a step towards this?